On Fri, 2005-04-22 at 15:27 -0400, Bryce McKinlay wrote: > Firstly, please don't ever put formatting and code changes in the same > patch! This is bad because it makes it difficult to distinguish code > changes from changes that are purely reformatting.
Yes I know, sorry, that was an oversight on my part. > Secondly, some of the formatting changes you made go against out > established style. We break lines at 80-columns unless there is no way > to cleanly do so. Also, 2-char indenting should be used for all methods, > including "static" blocks. Ok, to be honest I didn't look to closely at the result of formatting, I'd just ran it through jalopy. So I'm not sure why that happened. Apologies for the inconvenience. /Sven _______________________________________________ Classpath mailing list [email protected] http://lists.gnu.org/mailman/listinfo/classpath
