Hi there, I had a look at the mauve regressions. Here are my comments so far:
> -PASS: gnu.testlet.javax.swing.JLabel.Icon (number 6) > -PASS: gnu.testlet.javax.swing.JLabel.Icon (number 7) > +FAIL: gnu.testlet.javax.swing.JLabel.Icon (number 6) > +FAIL: gnu.testlet.javax.swing.JLabel.Icon (number 7) I fixed this. This was caused by the regressions in SwingUtilities.layoutCompoundLabel below. > -PASS: > gnu.testlet.javax.swing.text.AbstractDocument.BranchElement.getElementIndexNullPointer > (number 1) > +FAIL: > gnu.testlet.javax.swing.text.AbstractDocument.BranchElement.getElementIndexNullPointer: > AbstractDocument.BranchElement.getElementIndex should throw NPE when it has > no children (number 1) Fixed. I added some more tests and fixed up the Branch- and LeafElement. > +FAIL: gnu.testlet.javax.swing.text.AbstractDocument.ElementChange: uncaught > exception: java.lang.NullPointerException This is strange and non-trivial. Could probably make removing stuff in JTextAreas impossible. Must investigate more. > +FAIL: uncaught exception loading > gnu.testlet.javax.swing.text.DefaultStyledDocument.ElementBuffer.StyledDocument2: > java.lang.NullPointerException > +FAIL: uncaught exception loading > gnu.testlet.javax.swing.text.DefaultStyledDocument.ElementBuffer.StyledDocument3: > java.lang.NullPointerException Well, these are weird. But the ElementBuffer is still shaky and we probably won't get these fixed for 0.21 (or whatever it will become). > -PASS: gnu.testlet.javax.swing.text.MaskFormatter.MaskFormatterTest: valid > output (number 7) > +FAIL: gnu.testlet.javax.swing.text.MaskFormatter.MaskFormatterTest: uncaught > exception at "valid output" number 2: java.lang.NullPointerException Haven't looked at it yet. > -PASS: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: TC-text > (number 3) > +FAIL: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: TC-text > (number 3) > -PASS: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: TR-text > (number 3) > +FAIL: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: TR-text > (number 3) > -PASS: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: CL-text > (number 2) > +FAIL: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: CL-text > (number 2) > -PASS: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: CC-text > (number 2) > -PASS: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: CC-text > (number 3) > +FAIL: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: CC-text > (number 2) > +FAIL: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: CC-text > (number 3) > -PASS: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: CR-text > (number 3) > +FAIL: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: CR-text > (number 3) > -PASS: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: BC-text > (number 3) > +FAIL: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: BC-text > (number 3) > -PASS: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: BR-text > (number 3) > +FAIL: gnu.testlet.javax.swing.SwingUtilities.layoutCompoundLabel: BR-text > (number 3) Fixed completely. Some tests were not quite right (checking for fixed value when they should take font metrics into account), but some were real regressions which are fixed now. > -PASS: gnu.testlet.javax.swing.plaf.metal.MetalComboBoxUI.getDisplaySize > (number 2) > -PASS: gnu.testlet.javax.swing.plaf.metal.MetalComboBoxUI.getDisplaySize > (number 3) > -PASS: gnu.testlet.javax.swing.plaf.metal.MetalComboBoxUI.getDisplaySize > (number 4) > +FAIL: gnu.testlet.javax.swing.plaf.metal.MetalComboBoxUI.getDisplaySize > (number 2) > +FAIL: gnu.testlet.javax.swing.plaf.metal.MetalComboBoxUI.getDisplaySize > (number 3) > +FAIL: gnu.testlet.javax.swing.plaf.metal.MetalComboBoxUI.getDisplaySize > (number 4) These particular tests pass here, but number#5 fails. But according to the comment in the testcase this is a strange issue anyway. > -PASS: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getMinimumSize > (number 2) > -PASS: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getMinimumSize > (number 3) > +FAIL: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getMinimumSize > (number 2) > +FAIL: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getMinimumSize > (number 3) These pass here. > -PASS: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getPreferredSize > (number 2) > -PASS: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getPreferredSize > (number 3) > +FAIL: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getPreferredSize > (number 2) > +FAIL: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getPreferredSize > (number 3) These pass also. > -PASS: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getDisplaySize > (number 2) > -PASS: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getDisplaySize > (number 3) > -PASS: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getDisplaySize > (number 4) > +FAIL: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getDisplaySize > (number 2) > +FAIL: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getDisplaySize > (number 3) > +FAIL: gnu.testlet.javax.swing.plaf.basic.BasicComboBoxUI.getDisplaySize > (number 4) Same as MetalComboBoxUI.getDisplaySize. These pass, but #5 fails, but is possibly known. > Weird exception: > gnu.testlet.gnu.javax.swing.text.html.parser.support.Parser.HTML_parsing > gnu.testlet.gnu.javax.swing.text.html.parser.support.Parser.HTML_randomTable Indeed. Weird. Don't know what to do about it. Maybe Audrius can have a look? /Roman
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
