On Tue, 2008-12-09 at 18:15 -0500, Peter Memishian wrote: > > > http://zhadum.east.sun.com/ws/clearview/clearview-ipmpdev/webrev > > > > I took me a while to go back and wrap my head around this code, and > > based on our conversation yesterday, I think the fix makes sense. I > > don't see any obvious issues. One tricky bit was figuring out how we're > > sure that we won't accidentally neglect to start the mld timers in some > > cases, but metaphorically speaking, I believe that the last one to leave > > the room will indeed shut off the lights. > > Yes, and by having the last one do it we know there's no risk of deadlock. > I've updated the webrev with some comment fixes to the IPSQ fix, and a > couple of other fixes:
Looks fine. -Seb
