Peter Memishian writes:
>  > Yes, I agree with that.  At the point where IPIF_DUPLICATE is cleared
>  > in ip_ndp_recover, we should no longer have a running recovery timer.
>  > 
>  > ndp_do_recovery could check this and cancel the timer before doing
>  > qwriter_ip on ip_ndp_recover.
> 
> So you'd rather I do the check/clear in ndp_do_recovery() and not
> ip_ndp_recover()?

It makes slightly more sense to me in ndp_do_recovery, but either
would work.

>  OK, I can make that change.  BTW, I also added ASSERTs
> to check that ipif_recovery_id is 0 before we set it in ip_ndp_excl() and
> ip_arp_excl() to make future problems easier to catch.

That makes sense.

-- 
James Carlson, Solaris Networking              <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677

Reply via email to