On Tue, 2008-12-02 at 18:57 -0500, Peter Memishian wrote: > > On Tue, 2008-12-02 at 18:03 -0500, Peter Memishian wrote: > > > > > > http://cr.opensolaris.org/~seb/webrev.6774464/ > > > > > > > > I've re-spun the webrev. > > > > > > Looks good, but why EBUSY in ipnet_populate_if()? > > > > Good question, I debated which error code to return here with myself, > > and couldn't come up with a truly appropriate one. Since we don't know > > why we don't have a net handle, the choice of error code becomes > > somewhat arbitrary (this is the error code that will be returned by > > _init()). I'd welcome better suggestions. I chose EBUSY since the > > likely reason for a lack of a handle is a stack shutdown, and the stack > > was "busy" shutting down when we attempted the lookup... Not very > > convincing, I know. :-} > > OK. I guess the old EINVAL standby would've been fine by me, or ENETDOWN > if you're trying to get cute.
Heh, I like ENETDOWN. I'll use that. Thanks, -Seb
