> Could anybody please codereview the firx for the following CR:
>
> 6761558 DLPI notification support broke libdlpi API for raw sessions
>
> The webrev is at:
>
> http://cr.opensolaris.org/~girishmg/libdlpi/
Thanks for picking this up. A few comments:
* The new logic will plow on to line 1493 and beyond if it
receives a malformed DL_NOTIFY_IND. It should throw it away
and continue like the old code did at line 1483.
* Similarly, I'm confused why we no longer `continue' after
processing the DL_NOTIFY_IND. That is, why was 1487 removed?
* Please remove all the additional ()'s you've added. It just
clutters up the code. Likewise for the needless `int' cast
on line 1486; these types are compatible without the cast.
* Rather than pepper LINTED's in, please just cast ctl.buf to
`void *' first -- e.g.:
(*(t_uscalar_t *)(void *)ctl.buf == DL_NOTIFY_IND
This accomplishes the same thing (clues lint in that the cast is
safe) without having to annotate the code.
* In the comment at 1395-1398, should it be "; see
dlpi_enabnotify(3DLPI)"? Also, the second sentence doesn't
seem important here.
--
meem
