Michael Hunter wrote: >... >In dladm_wlan_wpa_get_sr() you memcpy(we_bytes, ssid, ssid_len) which >just happens to work because the array is set to 0 by the caller >although I don't see that being stated explictly. You should state >that this is the assumption somewhere close by or terminate the strings. > > No assumption here, it's caller's reponsibility to decide how to process return values, since we provide the ssid and its length (ssid_len).
>No bugs here I think but maybe it would be worthwhile to play a little >slower with strings. > >In wpa_supplicant.c:117 should this this be isprint() or is the ssid us >ascii centric? Should the replacement character depend on locale? > > Yes, the isprint() is better, and the replacement character doesn't depend on locale. Please file bugs against any problem you found. -- Quaker
