Sebastien Roy wrote: > In implementing the hoplimit and encaplimit properties, a question > regarding the pd_check interface popped up. Why does _every_ > implementation of pd_check allocate the val_desc_t? They all do the > exact same thing, which is: > > vdp = malloc(sizeof (val_desc_t)); > if (vdp == NULL) > return (DLADM_STATUS_NOMEM); > > I don't understand why the caller isn't doing that instead and passing in > a pre-allocated val_desc_t as the 4th argument. The caller already knows > how many to allocate, since it also passes in the val_cnt argument. > This code is following the convention of the old wifi linkprop, and I agree this should be optimized.
I will make the changes. Thanks - Cathy
