Peter Memishian wrote: > One of the remaining tasks I had on my list was to see what could be done > to tighten the dladm usage message (which is starting to get pretty long). > One possible thing to trim is the "-d <dev>" option in the aggr > subcommands -- e.g., we currently have: > > create-aggr [-t] [-R <root-dir>] [-P <policy>] [-L <mode>] > [-T <time>] [-u <address>] [-d <dev> | -l <link>] > <key|link> > modify-aggr [-t] [-R <root-dir>] [-P <policy>] [-L <mode>] > [-T <time>] [-u <address>] <key|link> > delete-aggr [-t] [-R <root-dir>] <key|link> > add-aggr [-t] [-R <root-dir>] [-d <dev> | -l <link>] ... > <key|link> > remove-aggr [-t] [-R <root-dir>] [-d <dev> | -l <link>] ... > <key|link> > > ... but by dropping -d from the usage message (which we are deprecating > anyway since we want people to use link names), this could be simplified to: > > create-aggr [-t] [-R <root-dir>] [-P <policy>] [-L <mode>] > [-T <time>] [-u <address>] [-l <link>] ... <key|link> > modify-aggr [-t] [-R <root-dir>] [-P <policy>] [-L <mode>] > [-T <time>] [-u <address>] <key|link> > delete-aggr [-t] [-R <root-dir>] <key|link> > add-aggr [-t] [-R <root-dir>] [-l <link>] ... <key|link> > remove-aggr [-t] [-R <root-dir>] [-l <link>] ... <key|link> > show-aggr [-pPLx][-s [-i <interval>]] [<key|link>] > > Of course, the dladm command would continue to accept -d and the manpage > would make it clear that -d is still available. > > Thoughts?
I like it. Along the same lines, the usage could drop "key", but the man page could discuss that a key is accepted instead of a link name where appropriate for backward compatibility. While this doesn't save any more lines of output, it is consistent with the idea of dropping deprecated usage out of the usage output. -Seb
