On Mon, 2006-10-02 at 22:00 +0800, Peter Memishian wrote:
> (As an side, I wonder if the non-DL_VERSION_2
> code has any purpose, given that snoop, dhcpagent, and other userland
> programs won't work with them.  Maybe we should just torch this cruft?)

I'd be surprised if IP itself works correctly over a DL_VERSION_1
driver.  There only a single check for dl_version in the entirety of the
ip module, and even there the comment was botched. :-)  rom ip_if.c:

        /*
         * When the new DLPI stuff is ready we'll pull lengths
         * from dlia.
         */
        if (dlia->dl_version == DL_VERSION_2) {

The code goes on to "pull lengths from dlia" using the "new DLPI stuff".
Whoever added DL_VERSION_2 code either couldn't read English, or was
just plain sloppy.

-Seb



Reply via email to