> > I've updated http://atlantic.east/ws/meem/physaddr/webrev; please let me
 > > know if the revised ip_reprocess_ioctl() and ill_set_phys_addr_tail()
 > > match what you wanted.
 > 
 > I've looked at the code and have no substantive comments.
 > 
 > ip_if.c:
 > 
 > * 23657: one too many "their"

Doh -- will fix.

 > Regardless of my lack of finding anything useful to comment on, at least
 > this lets me see what's coming up in this code.  As part of the
 > tunneling work, I'm introducing DL_CURR_DEST_ADDR as an address type
 > that can show up in notifications and DL_PHYS_ADDR_ACK.  It's also one
 > more address type we'll request when sending down the sequence of
 > DL_PHYS_ADDR_REQ's in ill_dl_phys().

Seems like that should fit in smoothly.

Thanks for the review -- I know it's headache-inducing stuff.
-- 
meem

Reply via email to