On Thu, 2008-10-30 at 12:31 -0400, Peter Memishian wrote: > > Phil provided some final spec updates for PSARC 2006/475 that I'll send > > to the case log. They are: > > > > Original Interface New Interface Comment > > ------------------------------------------------------------------------- > > DL_IOC_IPNET_INFO DLIOCIPNETINFO <sys/dlpi.h> > > ips_register_hook() ipobs_register_hook() (Project > Private) > > ips_unregister_hook() ipobs_unregister_hook() (Project > Private) > > zoneid zone snoop keyword > > PRIV_IP_OBSERVABILITY PRIV_NET_OBSERVABILITY > > A few comments: > > * Where's DLPI_DEVIPNET and DLPI_IPNETINFO?
These need to be added. > or > DLPI_EIPNETINFONOTSUP? (Also, did the manpage get updated > to cover that error code?) No, that needs to be done. > > * Didn't net_getlif_flags() get renamed to net_getlifflags()? Yes. > > * Why are we ARC'ing <inet/ipnet.h> as Committed? This seems > like a project-private header at most. I believe it was because at the time of filing the case, this header contained "struct dl_ipnet_info" (which is now dl_ipnetinfo_t) which was committed. Since this is actually in <sys/dlpi.h>, we need to change that. > * It appears from the inception materials that the original names > of the registration functions were ip_*_cb, not ips_*_hook(). The opinion and the final materials diverged, and the opinion got these wrong. They were ip_*_cb() in the inception materials, and were changed to ips_*() in the commitment materials. Regardless, they're now different. > > * If we're going to include the ip_*register_hook() API, why do > we omit ipobs_init(), ipobs_fini() and ipobs_hook()? Because those aren't an API, but functions internal to the ip module. The hook registration functions are functions used by modules other than ip to get access to packets. > > * Why are we classifying the net_* and NE_* stuff as Committed? That is because the rest of the netinfo API is Committed. I'll re-send updates to the text in a moment. Thanks, -Seb
