Liane Praza wrote:
> Peter Memishian wrote:
>> > Here's the webrev:
>> >
>> > http://cr.opensolaris.org/~seb/webrev-smf/
>>
>> As workarounds go, seems good. The formatting of 90-92 would be slightly
>> preferable as:
>> state=`svcprop -p restarter/state \
>> datalink-management:default 2>/dev/null`
>>
>> Also, the paranoid might prefer "network/datalink-management" to
>> datalink-management.
>
> We do try to encourage not taking advantage of the svc* commands fnmatch
> capabilities in scripts.
I've now specified the network/.
>
>> Are you confident that 5 seconds is enough?
>
> Ditto on that question. I'd be tempted to give it more time. (As a
> data point, the network/physical:[nwam|default] start method timeouts
> are both 600 seconds. Anything under a minute would probably not be out
> of the realm of reasonable. I'd probably choose something between 10
> and 30 seconds, but that's only a few seconds of consideration better
> than a wild guess.)
As I mentioned in a previous message, in my testing, the time to come
online has ranged from between 0 and 1.x seconds. I can increase the
timeout to 30 just in case something nasty is going on with svc.startd.
> Also, before exiting on line 100, it'd be nice to print out a message
> about what went wrong so that a system that followed this codepath has
> something helpful in the logfile.
How about the following?
if [ "$state" != "online" ]; then
echo "The network/datalink-management service \c"
echo "could not be enabled."
exit $SMF_EXIT_ERR_CONFIG
fi
Thanks,
-Seb
