Peter Memishian wrote: > > I mostly fixed the comment changes, thinking they were trivial and left > > other Sun cstyle error alone. I can see how it is distracting while > > reviewing the actual changes. > > It's more than distracting -- it's incorrect. Code for libpcap follows > its own style
It does? :-) Most files mostly use something akin to ANSI C-ified KNF (not surprising, given that LBL is run by UCB :-)), which was the Sun style back when I was there (in the days when dinosaurs^WSun-3's walked the earth). That's largely the style I use, but I've gotten into the habit of leaving parentheses out of the value in a return statement, but I might've let that creep into stuff I've written in libpcap - on the other hand, there was a mix of "return x;" and "return (x);" back in libpcap 0.4, long before I had anything to do with it. Some files added later, and pcap-linux.c after it was rewritten from scratch to that it actually worked right, have styles that are a bit different. So there isn't really *a* style. > and must not be changed to conform to Sun's cstyle. So what *were* the changes? > Likewise, new files like pcap-libdlpi.c need to follow the existing > libpcap style. ...except that, at least in the case of, for example, return statements, there *is* no existing style, even if you include only the files that were there in libpcap 0.4.
