sagun shakya wrote:
> sagun shakya wrote:
>> Sebastien Roy wrote:
>>> pcap-int.h:
>>>
>>> * 71-98: These only apply when compiling with DLPI support.  Perhaps 
>>> Guy can answer this:  Should there be some sort of #ifdef to make sure 
>>> that these symbols don't pollute the namespace when compiled on other 
>>> platforms?
>>>
>>> * 376-385: Same comment here.
>>>
>>>     
>> When compiling with libdlpi, a #ifdef HAVE_LIBDLPI can be done but for 
>> just dlpi, a HAVE_DLPI would need to be defined.
>>   
> Another solution and probably a simpler one, is to just add a dlpisubs.h 
> header  file.

Yes, I think that would work just fine.

Thanks,
-Seb

Reply via email to