On (03/23/07 18:58), Peter Memishian wrote:
> Thiru/Sowmini,
>
> There are a number of places in Nevada where we do something like:
>
> if ((dst_ill->ill_group != NULL) ||
> --> (ire->ire_ipif->ipif_flags & IPIF_DEPRECATED) ||
> (connp != NULL && ire->ire_zoneid != zoneid &&
> ire->ire_zoneid != ALL_ZONES) ||
> (dst_ill->ill_usesrc_ifindex != 0)) {
> ipaddr_t saddr = ire->ire_ipif->ipif_src_addr;
> --> src_ipif = ipif_select_source(dst_ill, saddr,
> zoneid); ^^^^^^^
>
:
:
> Is there any issue with changing these callers to use
> ire->ire_ipif->ipif_ill instead? (Basic testing seems to suggest not.)
Seems like it should be ok. Most callers (ipmp/vni are the exceptions here)
seem to set the dst_ill to ire->ire_ipif->ipif_ill anyway, and ipmp/vni
go through ip_newroute_get_dst_ill, which you have altered in your ws.
Thirumalai may have more insight into the subtleties.
--Sowmini
