> Below is the webrev. > http://jurassic.sfbay/net/aquila.prc/export/home/cathy/snv-dev/webrev/index.html >
Cathy, The general scheme looks compatible with Brussels viewpoint, but a couple of questions: why is there a difference between arg2 in the following signatures: typedef dladm_status_t pd_getf_t(const char *, char **, uint_t *); typedef dladm_status_t pd_setf_t(const char *, val_desc_t *, uint_t); i.e., why don't they both take val_desc_t * as the second arg, which seems to be more general? Also, the third arg in the pd_setf_t signature looks a bit confusing. Does this indicate the count of number of elements in vd_val? or is it the number of val_desc_t elements itself? (Could use some comments in the code, since its hard to remember these semantics) --Sowmini
