Cathy Zhou wrote: > Dan Groves wrote: >> Hi, >> >> I posted a new link ID management API document at: >> >> http://www.opensolaris.org/os/project/clearview/uv/link_id_management.pdf >> > It looks good. Some initial comments at the first glance: > > 1. This type enumerates the different link classes supported. The > enumeration consists of: DLADM_CLASS_PHYS ... > > Please be clear the listed classes are only the ones supported for now, > we'd expect other new classes be added, for example, DLADM_CLASS_IPTUN. >
I added a statement that the list only includes those link classes defined at the time of the document's writing. The list may grow in the future. > 2. dladm_walk_linkids > > dladm_status_t dladm_walk_link(void (*fn)(const char *, void *), > void *arg, dladm class t class, uint t flags) > > I would think that the signature of the function be: > > dladm_status_t dladm_walk_link(void (*fn)(dladm_linkid_t, void *), > void *arg, dladm class t class, uint t flags) > You're correct, that's a typo. Also, the function name should be dladm_walk_linkids. > 3. How to get the link name, link class from one specific dladm_conf_t? > I'll add an example in the examples section. thanks, Dan
