Meem, It looks pretty good overall. I looked at only some parts of the code, but I didn't find any major issue. Attached is the list of my comments.
I haven't really looked at the arp changes. Do you create the ace_t only on the IPMP meta arl ? Is this true even for our own ace_t's i.e. ACE_F_MYADDR ? The request from IP still goes up on the physical interface stream ? On IP's side, how does it look like ? the ire caches's ire_stq points to the physical interface, but the ire_ipif points to the IPMP meta interface ? If you can add some comments about these in the code later on, (your todo list :) that would be great. Thanks Thirumalai Peter Memishian wrote: >Thiru, > >As promised, you can find my new IPSQ IPMP code -- along with comments >that explain it -- at http://cr.grommit.com/~meem/ipmp-cv-dev/ > > > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: ipmp URL: <http://mail.opensolaris.org/pipermail/clearview-discuss/attachments/20070208/95e0daa5/attachment.ksh>
