Comments:
dhcpagent/select.c: 216: If it is an unused argument, why not just
remove it? Likewise for the short.
in.rarpd: thank you for all the cleanups. Nice improvement.
General: it looks like a lot of code cleanup. This is a good thing!
I only did dhcpagent and rarpd so far. I'll look at the rest later.
-- Garrett
sagun shakya wrote:
> The Clearview project delivered libdlpi(3LIB) as a public DLPI library
> and as a follow-on work to get all DLPI applications in ON to use the
> APIs provided by libdlpi, a set of application have been ported to
> libdlpi[1].
> Also, there are a couple of APIS being added to libdlpi, namely
> dlpi_arptype() and dlpi_iftype(). These functions allows a DLPI
> mactype value to be mapped to an ARP type value or an IP type value
> respectively. A PSARC fasttrack will be filed for these additional API.
>
> If you're off the SWAN webrev is located at:
> http://cr.grommit.com/~sshakya/webrev-libdlpi-port/
>
> If you have access to the SWAN, webrevs are located at:
> http://zhadum.east.sun.com/export/ws/ss150715/clearview-libdlpi-port-onnv/webrev/
>
>
>
> workspace & cscope:
> /net/zhadum.east/export/ws/ss150715/clearview-libdlpi-port-onnv
>
> Please provide your feedback to this list. The review timer is set for
> two weeks (05/08/07).
>
> To lessen the burden of code review, I requested reviews from several
> Sun employees who have worked or are working on the specific
> applications (assignments are listed below). However, comments from
> the community at-large and also review of the entire changes are welcome.
>
> Here are the list of DLPI applications and reviewers who kindly agreed
> on reviewing:
>
> James D. Carlson and Peter Memishian - dhcpagent, in.rarpd, libdlpi,
> libdladm, dladm and additional apis to libdlpi
> Donghai Han - zoneadm
> Grant Zhang or a team member of scsitgt-bj - libuuid
>
> The applications and related files are:
>
> 1. dhcpagent - DHCP client daemon
>
> usr/src/cmd/cmd-inet/sbin/dhcpagent/Makefile
> usr/src/cmd/cmd-inet/sbin/dhcpagent/dlpi_io.c
> usr/src/cmd/cmd-inet/sbin/dhcpagent/dlpi_io.h
> usr/src/cmd/cmd-inet/sbin/dhcpagent/interface.c
> usr/src/cmd/cmd-inet/sbin/dhcpagent/interface.h
> usr/src/cmd/cmd-inet/sbin/dhcpagent/packet.c
> usr/src/cmd/cmd-inet/sbin/dhcpagent/packet.h
> usr/src/cmd/cmd-inet/sbin/dhcpagent/request.c
> usr/src/cmd/cmd-inet/sbin/dhcpagent/select.c
> usr/src/lib/libdhcpagent/common/dhcp_stable.c
> usr/src/lib/libdhcputil/common/dhcp_inittab.c
> usr/src/lib/libdhcputil/common/dhcp_inittab.h
> usr/src/lib/libdhcputil/common/mapfile-vers
>
> 2. in.rarpd - RARP server
> usr/src/cmd/cmd-inet/usr.sbin/Makefile
> usr/src/cmd/cmd-inet/usr.sbin/in.rarpd.c
>
> 3. zoneadm - utility to administer system zones
> usr/src/cmd/zoneadm/Makefile
> usr/src/cmd/zoneadm/zoneadm.c
>
> 4. libuuid - UUID library
> usr/src/lib/Makefile
> usr/src/lib/libuuid/Makefile.com
> usr/src/lib/libuuid/common/etheraddr.c
> usr/src/lib/libuuid/common/etheraddr.h
>
> 5. libdladm changes needed to port libuuid
> usr/src/lib/libdladm/Makefile
> usr/src/lib/libdladm/amd64/Makefile
> usr/src/lib/libdladm/common/linkprop.c
> usr/src/lib/libdladm/sparcv9/Makefile
> usr/src/pkgdefs/SUNWcslr/prototype_i386
> usr/src/pkgdefs/SUNWcslr/prototype_sparc
> usr/src/pkgdefs/etc/exception_list_i386
> usr/src/pkgdefs/etc/exception_list_sparc
>
> 6. additional APIs to libdlpi
> usr/src/lib/libdlpi/common/libdlpi.c
> usr/src/lib/libdlpi/common/libdlpi.h
> usr/src/lib/libdlpi/common/mapfile-vers
>
> 7. dladm
> usr/src/cmd/dladm/dladm.c
>
> Thank you for your time.
>
> Sagun
>
> [1] Note that the changes above does not comprise of all the
> applications. These set of applications are needed to get the
> Clearview UV work completed.
>
> _______________________________________________
> networking-discuss mailing list
> networking-discuss at opensolaris.org
