Cathy Zhou wrote: > Sebastien Roy wrote: >> My feeling here is that the caller should determine whether he wants >> the configuration to persist or not, and I don't think that linkmgmtd >> should try and guess based on unrelated parameters. This could be >> resolved by having an additional flags field in the create structure >> which could take LINKMGMT_ACTIVE and/or LINKMGMT_PERSIST. >> > I did that only because from the existing input (the VLAN ID), it is > already enough information to derive whether this configuration needs to > be persistent or only temporary. > > But as you said, we could add additional flag.
Okay. >> Why not have the caller of the upcall pass up the class instead of a >> media type? This is the only place where ld_media is referenced, so >> there doesn't seem to be a purpose for it other than to derive a class. >> > This is because "class" is a concept in dladm only. I know now its > definition is in dls.h. But I will move it to libdladm.h. Okay. In that case I'll be adding a few more entries to that switch statement. :-) -Seb
