Hello Seb,

I looked at the following files:

usr/src/cmd/svc/milestone/net-physical .. OK
usr/src/cmd/svc/milestone/network-initial.xml.. OK
usr/src/cmd/svc/milestone/network-iptun.xml.. OK

usr/src/cmd/svc/milestone/net-init
usr/src/cmd/svc/milestone/net-iptun

Questions:
------------
Do we use following environment variables defined in 
/etc/default/inetinit (this is called in from net-init)

ACCEPT6TO4RELAY=NO
RELAY6TO4ADDR="192.88.99.1"

I didn't see them either in net-init or net-iptun. Though @ L73 of 
net-init I see reference to those variables in 'comments'. Can we get 
rid of those variables altogether from /etc/default/inetinit, if we are 
not using it.

usr/src/cmd/svc/milestone/Makefile
---------------------------------
@L45: Is it possible to order these services in the order they come up. 
It will be very helpful for people who want to understand in what order 
these network services come up. Unfortunately, today the only place you 
would know the order is in "comments" section of net-init.

usr/src/uts/common/os/policy.c
-------------------------------

L1739-1747, I guess, could be simply re-written to

int
secpolicy_iptun_config(const cred_t *cr)
{
        if (secpolicy_dl_config(cr) != 0)
                return (PRIV_POLICY(cr, PRIV_SYS_IPTUN_CONFIG, B_FALSE,
                        EPERM, NULL));
        return (0);
}

usr/src/lib/libdlpi/common/libdlpi.c.. OK
usr/src/lib/libdlpi/common/libdlpi_impl.h.. OK

thanks
~Girish

Reply via email to