On Thu, Aug 13, 2009 at 09:06:16PM -0700, Peter Memishian wrote: > > 1710-1720: > > if I read this correctly, this is passing the mac name to > > mac_client_open() which will result in the mac name being copied > > to bif_ifname. I think you want the real link name right? > > > > to get the real link name, the name arg to mac_client_open() > > should be NULL and flags should include > > MAC_OPEN_FLAGS_USE_DATALINK_NAME. > > Given that DLS also uses MAC_OPEN_FLAGS_USE_DATALINK_NAME, would we end up > with multiple MAC clients that have the same name? >
I checked the code. looks like its safe to allow this. mci_name need not be unique. we identify the primary mac client (the one used by DLS) using the flag MAC_CLIENT_FLAGS_PRIMARY, not mci_name. pf_packet doesn't use this flag. when someone does a rename, these pf_packet mac clients will get renamed as well (by mac_rename_primary()). also, pf_packet mac clients do not create kstats (since they do not call mac_unicast_add()) so there won't be kstat collisions. eric
