On Tue, 2009-08-18 at 10:39 -0400, Sebastien Roy wrote: > On Tue, 2009-08-18 at 04:56 -0700, Eric Cheng wrote: > > > > 2017: > > add check for MBLKL(mp) > (ipha_t + icmp_t) or (ip6_t + icmp6_t)? > > ACCEPT: I won't do that here, but in the common iptun_input_icmp() input > path for all ICMP packets. ... > > > > 2424: > > possibly more header size checks needed. > > ACCERPT: this is where I'll add the checks you suggested for 1017.
I take that back, we unconditionally do a pullup in iptun_input_icmp(), and the ip module has already verified that the message contains an ICMP header (otherwise, we wouldn't be here). -Seb
