On Mon, 2009-08-31 at 10:35 -0400, Sowmini.Varadhan at Sun.COM wrote: > On (08/31/09 10:18), Sebastien Roy wrote: > > > > > > > > * 374-381: Would've expected this to be done by GLDv3, not by > > > each > > > > > individual driver (sigh). > > > > > > > > There are indeed warts in this driver API. > > > > > > Again, perhaps a CR? > > > > I've filed: > > 6877488 mac_get_prop() doesn't filter out bogus pr_flags > > maybe I'm missing the context here (since I've not been following the > thread) but, at least for DEFAULT, the driver has to know whether it's > being asked to return the default value or the current value, so it has > to check the DEFAULT flag. Without adding additional callback(s) > like mc_getprop_default, how can this be filtered in the GLD layer?
Yes, the driver has to know which flags are set so that it can do its job, but it shouldn't have to do sanity checking on the pr_flags value to make sure that bobus flags aren't set. Thinking about this a bit more, though, is the current implementation the way it is because it makes it easier to add new flags? -Seb
