Hi Tio I Think pixels should be avoided as size unit, with this update you're forcing the user of the overlay to define the sizes in pixel. why this?
apart from this, the new behavior is not documented. reto On Wed, Dec 16, 2009 at 12:24 AM, <[email protected]> wrote: > Author: ito > Date: Tue Dec 15 23:24:49 2009 > New Revision: 891071 > > URL: http://svn.apache.org/viewvc?rev=891071&view=rev > Log: > overlay appended to document.body instead of dom element wiht id tx-body, > minor bugfixes > > Modified: > > incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.web.resources.scripts/src/main/resources/org/apache/clerezza/web/resources/scripts/staticweb/overlay.js > > Modified: > incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.web.resources.scripts/src/main/resources/org/apache/clerezza/web/resources/scripts/staticweb/overlay.js > URL: > http://svn.apache.org/viewvc/incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.web.resources.scripts/src/main/resources/org/apache/clerezza/web/resources/scripts/staticweb/overlay.js?rev=891071&r1=891070&r2=891071&view=diff > ============================================================================== > --- > incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.web.resources.scripts/src/main/resources/org/apache/clerezza/web/resources/scripts/staticweb/overlay.js > (original) > +++ > incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.web.resources.scripts/src/main/resources/org/apache/clerezza/web/resources/scripts/staticweb/overlay.js > Tue Dec 15 23:24:49 2009 > @@ -45,16 +45,16 @@ > Overlay.show = function(bodyText, headerText, widthOverlay, heightOverlay) { > > if(widthOverlay == undefined || widthOverlay == "") { > - widthOverlay = "560px"; > + widthOverlay = 560; > } > if(heightOverlay == undefined || heightOverlay == "") { > - heightOverlay = "450px"; > + heightOverlay = 450; > } > > this.overlay = new YAHOO.widget.Panel("tx-assetsdetail", { > draggable: true, > - width: "560px", > - height: "450px", > + width: widthOverlay+"px", > + height: heightOverlay+"px", > constraintoviewport: true, > modal: true, > zIndex: 100, > @@ -72,7 +72,7 @@ > this.overlay.setHeader(headerText); > } > > - this.overlay.render("tx-body"); > + this.overlay.render(document.body); > $("#tx-assetsdetail").addClass("tx-window"); > > // if overlay is closed the overlay is removed from dom (default is > visibility: hidden) > @@ -86,8 +86,8 @@ > this.resize = new YAHOO.util.Resize("tx-assetsdetail", { > handles: ["br"], > autoRatio: false, > - minWidth: 560, > - minHeight: 300, > + minWidth: widthOverlay, > + minHeight: heightOverlay, > status: false > }); > > > >
