[
https://issues.apache.org/jira/browse/CLEREZZA-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hasan reopened CLEREZZA-38:
---------------------------
In representations.rdf
- In Property isIconFor
-- isIconFor is a DatatypeProperty, not an ObjectProperty, as it is defined now
-- property rdfs:isDefinedBy is incorrect
-- suggest to rephrase the definition to: "Points to a string specifying the
resource type for which the subject is an icon."
In ThumbnailService
- unused imports
- cannot import org.apache.clerezza.rdf.ontologies.EXIF
(org.apache.clerezza.rdf.ontologies/0.11-incubating-SNAPSHOT/org.apache.clerezza.rdf.ontologies-0.11-incubating-20091223.111515-4.jar
does not contain EXIF)
- In public getThumbnailUri
-- missing java doc for param width and height
- In private getThumbnailUri
-- it is assumed that the store always has EXIF.width and height properties for
each thumbnail
subject. I think bad things can happen and the store might not have these
properties for a
thumbnail, so getObjects(EXIF.width).next() might throw an exception.
-> Suggest to avoid this exception by using hasNext() and handle the missing
EXIF.width prop
accordingly for example ignore and continue the loop.
In AlternativeRepresentationGenerator
- getService may return null, therefore contentHandler.put can throw
NullPointerException.
(probably this is ok, since the method may throw RuntimeException and
node.addProperty happens after contentHandler.put)
- don't understand the purpose of the condition lastIndexOfDot >=
(oldUri.length() - 6)
in createThumbnailUri.
a short inline comments might help
In pom.xml of ...core
<description>Provides a Meta Data Generator that generates alternative
representations for data of various meta types</description>
<dependencies>
- typo "meta types"?
- would change "various" to image/* as mentioned in
AlternativeRepresentationGenerator
- would add that this bundle also provides a JAX-RS service to retrieve a
thumbnail of an
InfoDiscoBit via http redirection
> implement rest-service that retrieves the thumbnail uri for a InfoDiscoBit
> --------------------------------------------------------------------------
>
> Key: CLEREZZA-38
> URL: https://issues.apache.org/jira/browse/CLEREZZA-38
> Project: Clerezza
> Issue Type: New Feature
> Reporter: Manuel Innerhofer
> Assignee: Manuel Innerhofer
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
