I'm not sure what the advantage of having the binary build in the parent rather in the launcher is. I think it is possible that we might want to release the parent independently of the launcher (say we want to release a component that is not (yet) part of the launcher).
Reto On Mon, Nov 28, 2011 at 1:17 PM, Tommaso Teofili <tommaso.teof...@gmail.com> wrote: > > Hi Daniel, > > 2011/11/23 Daniel Spicar <dspi...@apache.org> > > > Hi all, > > > > Tommaso suggested that the when building the parent pom, the binary > > assembly of the tdb-launcher should be built as well. Currently the > > tdb-launcher module creates an appropriate assembly when the module is > > built. The executable jar is then placed in it target folder along with a > > readme file and a license and dependencies file. > > > > My first question is: Do we want to place the binary in the parent module's > > target folder? If so, do we want it in the tdb-launcher's target folder as > > well? > > > > that may be an option, however I don't know if it'd be the best one. > I think we should create a different assembly descriptor because of NOTICE, > README etc files which should be taken from the root directory. > > > > > > > My second question is: How does and where to will these the source and > > binary assemblies be deployed? > > > > The modules artifacts (not only the 'final binary') have for sure to be > deployed on Maven repository, however this binaries and sources packages > are usually deployed to Apache "dist" mirror in order to let people be able > to download them separately (not getting stuff using Maven). > > > > Is the release plugin capable to deploy them somewhere? Currently I only > > know of a capability to deploy to a maven repository. But because the > > binary and source assemblies are not libraries/jars that does not seem to > > be reasonable for those files. > > > > It is worth discussing if we want to create different profiles for default > > builds that are used by developers and for the release process. This means > > we could have the build behave in one way as default (e.g. the current > > behavior) and in another way when we do builds for releases (e.g. copy the > > binary from tdb-launcher to the parent module's target folders). Maybe > > there are additional tasks we want to perform for releases only. > > > > Maybe I just misunderstand some things. The release plugin is still > > somewhat of a mystery to me. > > > > I think the best option is start from where we are now and start producing > RCs in order to adjust them "along the way". > > Tommaso > > > > > > Daniel > > > > ---------- Forwarded message ---------- > > From: Daniel Spicar <daniel.spi...@trialox.org> > > Date: Wed, Nov 16, 2011 at 6:10 PM > > Subject: Re: Help on CLEREZZA-646 > > To: clerezza-dev@incubator.apache.org > > > > > > I have seen that a binary assembly is already performed by the > > tdb-launcher. I am currently copying this artifact to the parent's target > > folder. But how do we want this to work? And where should the artifact end > > up? Do we want to deploy it? I understood deploy to be for maven artifacts > > only and zip files are not maven artifacts. I am not sure if the release > > plugin correctly picks it up for signing etc. But testing this takes > > awfully long so I'll know later. > > > > Also, does anyone know what this in the parent.pom means exactly? > > > > "<!-- apache plugin repositories are to be removed before relase -->" (line > > 1380) > > > > On Wed, Nov 16, 2011 at 2:11 PM, Tommaso Teofili > > <tommaso.teof...@gmail.com>wrote: > > > > > Hi Daniel, > > > > > > for the release I think we're going to produce two artifacts: > > > - the source package which contains all the sources of the modules we > > chose > > > to release > > > - a binary package which could be used to launch Clerezza (sources could > > > not be included) > > > > > > The first artifact is already automatically generated when doing mvn > > > release:prepare (use also the -DdryRun=true parameter to try it, see also > > > [1]). > > > We discussed what the binary artifact should contain and Reto proposed > > that > > > it would just be the platform.launcher.tdb package with > > > README/NOTICE/LICENSE and dependencies. > > > > > > So it'd be good that this second step is automated in the parent POM > > > (using, for example, a separate Maven assembly descriptor) and this is > > what > > > I meant in my previous email. > > > > > > Sorry if it sounded not clear, I hope I clarified a bit :) > > > Tommaso > > > > > > > > > [1] : http://maven.apache.org/plugins/maven-release-plugin/ > > > 2011/11/16 Daniel Spicar <daniel.spi...@trialox.org> > > > > > > > Hi Thommaso, > > > > > > > > what do you mean with "We need now to add the platform.launcher.tdb jar > > > as > > > > the binary artifact for the release inside the parent pom"? I have time > > > to > > > > help but I'm not sure what it means? > > > > > > > > Regards, > > > > Daniel > > > > > > > > On Mon, Nov 14, 2011 at 1:04 PM, Tommaso Teofili > > > > <tommaso.teof...@gmail.com>wrote: > > > > > > > > > Hi guys, > > > > > I think so, everything seems ok with regards to RAT checks. > > > > > We need now to add the platform.launcher.tdb jar as the binary > > artifact > > > > for > > > > > the release inside the parent pom; if you have time to do that it'd > > be > > > > > super. > > > > > Then (I think) we are ready to create a new RC and call for a vote. > > > > > Tommaso > > > > > > > > > > 2011/11/14 Hasan Hasan <ha...@trialox.org> > > > > > > > > > > > ah ok thanks reto > > > > > > miss your email. so everything is settled? > > > > > > > > > > > > cheers > > > > > > hasan > > > > > > > > > > > > On Mon, Nov 14, 2011 at 10:35 AM, Reto Bachmann-Gmür < > > > r...@apache.org > > > > > > >wrote: > > > > > > > > > > > > > I think I've now added all the required headers or exclusions > > > > > directives, > > > > > > > mvn -Prat clean install now succeeds. > > > > > > > > > > > > > > Reto > > > > > > > > > > > > > > On Wed, Nov 9, 2011 at 9:35 AM, Tommaso Teofili > > > > > > > <tommaso.teof...@gmail.com>wrote: > > > > > > > > > > > > > > > In the meantime I'm going to disable maven-rat-plugin from > > > default > > > > > > > > execution to avoid useless CI fails. > > > > > > > > Tommaso > > > > > > > > > > > > > > > > 2011/11/8 Tommaso Teofili <tommaso.teof...@gmail.com> > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > there is a huge amount of files which lack the AL headers so > > > I'd > > > > > > kindly > > > > > > > > > ask for some help in this "exciting" task :P > > > > > > > > > Can anyone please join in ? > > > > > > > > > Regards, > > > > > > > > > Tommaso > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
