[
https://issues.apache.org/jira/browse/CLK-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694463#action_12694463
]
Adrian A. commented on CLK-515:
-------------------------------
This issue and patch is only to fix a typo where the false Util class was
imported (the Spring one instead of Apache commons - Both do the same).
> I suppose what would be nice (if we only had the time)
As I mentioned earlier, I volunteer to clean the click-examples. The other
issue(https://issues.apache.org/jira/browse/CLK-516) has a more "complete"
patch (I can't apply it myself to your SVN).
> 1 - Click Examples - Click + Cayenne
This is almost there if you apply the patch :) .
I could improve it by refactoring the services to interfaces to have a better
practice too :).
Also the Apache license text should not be displayed in examples because it
ruins their purpose.
> 2. Spring/Hibernate CRUD
A separate JIRA issue to track this would be good?
3. Your example of Spring + Cayenne is in the SVN. Maybe it just needs a small
upgrade to use the latest libs.
> PageLinkTreePage depends on Spring for only one method.
> -------------------------------------------------------
>
> Key: CLK-515
> URL: https://issues.apache.org/jira/browse/CLK-515
> Project: Click
> Issue Type: Bug
> Components: extras
> Reporter: Joseph Schmidt
> Priority: Critical
> Attachments: Remove_Spring_dependency.patch
>
>
> PageLinkTreePage depends on Spring framework for only a simple util method:
> org.springframework.util.ClassUtils#getShortName()
> (i guess ClickUtils too :( )
> Please remove that dependency. 1,5 Megabyte of jars are not proportional for
> a 4 line util method.
> I think this is a critical issue.
> thanks,
> Joseph
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
