[ 
https://issues.apache.org/jira/browse/CLK-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694766#action_12694766
 ] 

Malcolm Edgar commented on CLK-421:
-----------------------------------

Yeah I agree with Bob on this one, I like the Component idea, but should stay 
in Click Examples. 

In Click Examples developers can easily grab the source and use it themselves 
in their own applications.

> Move SourceViewer from examples to utils
> ----------------------------------------
>
>                 Key: CLK-421
>                 URL: https://issues.apache.org/jira/browse/CLK-421
>             Project: Click
>          Issue Type: Improvement
>            Reporter: Demetrios Kyriakis
>            Priority: Minor
>         Attachments: SourceViewerPanel.diff
>
>
> Please move the SourceViewer utility class from click-examples to some util 
> package inside click because:
> - it is usable in more places than just click-examples, and users duplicate 
> it all the time, by copy and paste.
> - it could be used even in error reporting to display nice source code where 
> errors appear.
> - even ClickClick has a duplicated class for SourceViewer
> - it would be much simpler to make other example webapplications 
> moredeveloper friendly if this
> class would be present in utils.
> - other concurrent frameworks don't have such an utility and display pure 
> text :).
> Thank you,
> Demetrios.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to