Hello Eddie, I respined the patch and cleaned up with your advice.
- Revert e1000 driver fixes, e1000 polling driver was sent with another patch on the list. - Revert unnecerary changes configure.in linuxmodule/Makefile.in. Thanks Eddie, - Rebase base commit to ede0c6b0a1cface05e8d8e2e3496ee7fcd5ee143. - Remove fixes for uintptr_t which was applied already. Please let me know if you concern anything else. Thanks! Joonwoo 2008/9/10 Eddie Kohler <[EMAIL PROTECTED]>: > Joonwoo, Adam, > > Thank you thank you thank you for all your work on the Linux 2.6.24 patch. > > Let's get it in. > > I have a bunch of questions. > > - Linux's build process has historically been one of the most annoying > things to get right. So I'm a little concerned about the following changes: > > * Add #include <linux/autoconf.h> to #include <click/config.h> > (The Linux 2.6 build process, including 2.6.26.2, #includes this file > automatically, with a -include option given to GCC.) > * Add #include <linux/version.h> to #include <click/config.h> > * Remove -I$linuxdir/include/asm/mach-generic/ from LINUX_CFLAGS > * Add -I$linuxdir/include/asm/mach-generic and > -I$linuxdir/include/asm/mach-default to LINUX_CFLAGS > > Can you guys explain these changes? > > More soon. > Thanks, > Eddie > > > Joonwoo Park wrote: >> >> Hello Eddie, >> >> This patch is for click to work on patched linux-2.6.24.7. >> It was revised to be applied for the lastest git tree >> (a7dd5c93a51b3b5b8cd4a177ef379492c27859bf: click-combine >> documentation: Mention that RouterLink is fake.) >> >> Initial patch was done by Adam Greenhalgh" <[EMAIL PROTECTED]>. >> >> Please consider applying this patch. >> >> Thanks, >> Joonwoo > >
0001-oneshot-click-1.6.patch-1.gz
Description: GNU Zip compressed data
_______________________________________________ click mailing list click@amsterdam.lcs.mit.edu https://amsterdam.lcs.mit.edu/mailman/listinfo/click