Hi,

I ran into a bug with expensive_uniqueify running kernel level click with
the recent 2.6.24.7 kernel patches. The annotations were being shifted an
incorrect amount. Since our skbuffs use offsets, the correct amount to
shift is only any extra_headroom. A patch is attached for anyone using the
2.6.24.7 kernel.

The 2.6.24.7 kernel with the 7.6.15.5 e1000 driver has been working well
for us.

Thanks!
Kevin Springborn
--- lib/packet.cc
+++ lib/packet.cc
@@ -488,7 +488,12 @@
 #  endif
 # endif
 
+# ifdef NET_SKBUFF_DATA_USES_OFFSET
+  shift_header_annotations(extra_headroom);
+# else
   shift_header_annotations(nskb->head + extra_headroom - old_head);
+# endif
+
   return static_cast<WritablePacket *>(this);
 
 #else		/* User-level or BSD kernel module */
_______________________________________________
click mailing list
[email protected]
https://amsterdam.lcs.mit.edu/mailman/listinfo/click

Reply via email to