I agree with the warning. I don't really see cache benefits to preventing these structures from growing dynamically, though. Can't we just do that?
E Marko Zec wrote: > On Friday 17 October 2008 15:33:16 Harald Schiöberg wrote: >> Marko Zec wrote: >>> On Friday 17 October 2008 02:26:01 Eddie Kohler wrote: >>>> Hi Harald, >>>> >>>> We have a problem. It looks like this is a bug in DirectIPLookup. >>>> If I use RadixIPLookup instead of Direct, everything works fine. >>>> I did not write DirectIPLookup; I have ccd Marko Zec, who did. >>>> Maybe he can help. >>> Hmm it's both a bug and a feature, depending on how you look at >>> it... >> Since its both, reverting to plan B: Issue a warning. Patch is >> attached. > > Sounds reasonable. IMO warning messages should be printed in > add_route() handler, not in configure() which is run only at element > instantiation time, because it's possible to modify routing table > contents on the fly at any time while click runs... > > Cheers, > > Marko > _______________________________________________ click mailing list click@amsterdam.lcs.mit.edu https://amsterdam.lcs.mit.edu/mailman/listinfo/click
