On Fri, 10 Sep 2021 23:34:19 GMT, Alisen Chung <github.com+90066231+alisench...@openjdk.org> wrote:
>> removed support for running demo from applet for J2Ddemo and SwingSet2 >> same PR as 8205137: Remove Applet support from SwingSet2 #5400 (changed >> branch name) > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > 8205137: Reverted accidental code reformat > > Reviewed-by: alichung https://www.oracle.com/technetwork/java/codeconventions-150003.pdf didn't say anything relevant. The still-in-draft update to this http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-import-statements which is focused on OpenJDK developers says Import statements should be sorted… …primarily by non-static / static with non-static imports first. …secondarily by package origin according to the following order java packages javax packages external packages (e.g. org.xml) internal packages (e.g. com.sun) …tertiary by package and class identifier in lexicographical order So that isn't yet "blessed" and could be written a bit more clearly but I could also imagine quibbles these days like "group imports by module, starting with java.base" as the primary one. And imports from named modules go first .. And I can imagine folks wanting to place exception imports after other imports .. So I don't think there is any agreed upon set of rules to follow although most folks when you get down to the specific package do place them in lexical order Here I note that the pre-existing wild card imports were of javax.swing followed by java.awt* and the change is preserving that so I don't have a strong opinion on that nor do I think I would insist on lexical ordering but I also would be quite fine if the fixer is OK to make that change. src/demo/share/jfc/SwingSet2/DemoModule.java line 45: > 43: import java.util.*; > 44: import java.io.*; > 45: import java.net.*; Oops. I missed we still have wildcards here src/demo/share/jfc/SwingSet2/TabbedPaneDemo.java line 47: > 45: import java.util.*; > 46: import java.io.*; > 47: import java.net.*; And also stilll have them here. ------------- PR: https://git.openjdk.java.net/jdk/pull/5401
