On Thu, 23 Sep 2021 05:08:26 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> The test sometimes fail on macos12 citing "Action has not been received". 
>> Seems like some key events sometimes are not received reliably. 
>> Proposed fix is to apply mach5 stability fixes which is to set autodelay to 
>> 100ms, move frame to center of screen from top-left, added extra 
>> waitForIdle(), wait for 1 sec after frame is made visible.
>> Additionally, it is seen that it mixes Util.hitKeys and 
>> robot.keyPress/Release. Changed to make it use robot.keyPress/keyRelease all 
>> times. Also, updated test to have specific error message for specific 
>> keyevent so that we know which keyevent is not received in case it fails 
>> again.
>> 
>> Run on mac12 and all other platforms multiple times and test run is green. 
>> Link in JBS.
>
> Prasanta Sadhukhan has updated the pull request with a new target base due to 
> a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains three additional 
> commits since the last revision:
> 
>  - Problemlist update
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8273578
>  - 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

Marked as reviewed by jdv (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5564

Reply via email to