On Thu, 23 Sep 2021 07:51:39 GMT, Andrey Turbanov 
<[email protected]> wrote:

>> There are few places in code where manual `for` loop is used with Iterator 
>> to iterate over Collection.
>> Instead of manual `for` cycles it's preferred to use enhanced-for cycle 
>> instead: it's less verbose, makes code easier to read and it's less 
>> error-prone.
>> It doesn't have any performance impact: java compiler generates similar code 
>> when compiling enhanced-for cycle.
>> This is continuation of 
>> [JDK-8258006](https://bugs.openjdk.java.net/browse/JDK-8258006)
>
> Andrey Turbanov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8274016: Replace 'for' cycles with iterator with enhanced-for in 
> java.desktop
>   cleanup toArray conversion in SimpleRenderedImage

src/java.desktop/share/classes/com/sun/imageio/plugins/common/SimpleRenderedImage.java
 line 286:

> 284: 
> 285:         // Copy the strings from the ArrayList over to a String array.
> 286:         String[] prefixNames = names.toArray(new String[0]);

Looks like the comment became useless

-------------

PR: https://git.openjdk.java.net/jdk/pull/5578

Reply via email to