On Thu, 23 Sep 2021 21:50:57 GMT, Phil Race <[email protected]> wrote:

> > > > I checked for when the user maximizes the window and tiles to the left 
> > > > or right of the screen and both seem to work.
> > > 
> > > 
> > > But what is the flag value? Is it true or false? If it's true and 
> > > everything works maybe we do not need this line at all?
> > 
> > 
> > Oh the flag is always true. And removing the line completely fixes the bug 
> > and doesn't have any problems with fullscreen or tiling.
> 
> Surely that was there for a reason ? Looks like it might be important for the 
> synthesized full screen mode ?
> It was added in that location by this fix : 
> https://mail.openjdk.java.net/pipermail/awt-dev/2013-November/006372.html
> and that just moved it a few lines so it was already in use before then.

Sergey did mention it was added as a fix for JDK-8028485 earlier too. Reverting 
the changes made by JDK-8028485 doesn't seem to reintroduce the fullscreen not 
firing mouseEntered bug, so I'm not exactly sure how that fix worked. Behavior 
seems to be the same regardless of the position of the [AWTWindow 
synthesizeMouseEnteredExitedEventsForAllWindows] line.

> 
> Does the test from there still pass ? Any others fail ?

All manual and automatic tests are passing on macOS.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5497

Reply via email to