On Mon, 27 Sep 2021 13:34:44 GMT, Pankaj Bansal <[email protected]> wrote:

>> The function documentation for oneTouchExpandableChanged states that the 
>> function does couple of things, but in reality  it only does those things if 
>> the Look and Feel supports the supportsOneTouchButtons. In case the Look and 
>> Feel does not support supportsOneTouchButtons, this functions just returns 
>> in beginning and does not do anything.
>> This change clarifies the above in function documentation.
>
> Pankaj Bansal has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Changes according to JBS discussion

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
 line 379:

> 377:     /**
> 378:      * Messaged when the oneTouchExpandable value of the JSplitPane the
> 379:      * divider is contained in changes. Will create the

I guess "value of the current JSplitPane divider" makes more sense. 
Also, I guess leftButton,rightButton wll be created not only if they are null 
but also when oneTouchExpandable property is set as per code..It might seem to 
user from current wording that left/right button will be set if they are null 
even if oneTouchExpandable is not set.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5263

Reply via email to