On Thu, 30 Sep 2021 12:02:08 GMT, Artem Semenov <[email protected]> wrote:
>> We've extended the current implementation of TableAccessibility to make sure
>> that individual cells are voiced when navigating with the keyboard.
>
> Artem Semenov has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR.
I tested the table accessibility during cell navigation and it looks fine. I
have given minor comment, but this fix looks good overall.
src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableAccessibility.m line
235:
> 233: for (NSNumber *col in selectedColumns ) {
> 234: CellAccessibility *cell = [self
> accessibilityCellForColumn:[col integerValue] row:[row integerValue]];
> 235: // if ([self isAccessibleChildSelectedFromIndex:[cell
> accessibilityIndex]]) {
Can we just get rid of these lines instead of commenting the code unless there
is specific reason to do it like this?
-------------
Marked as reviewed by pbansal (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5466
