On Fri, 29 Oct 2021 03:49:04 GMT, Phil Race <p...@openjdk.org> wrote:

> Regardless, there's value in the test updates, although my existing comments 
> on the specifics there still stand.

Should I pursue with the test updates with this PR as it seems it can be 
addressed by product change? I am not sure what specifics needs to be 
addressed...Are the below ones the one?

> And is an offset of 10 enough ? Its a bit arbitrary and cursors could be a 
> larger shape or different orientation

SInce I am going in opposite direction of cursor by using (-10,-10) I guess it 
should be ok since normally cursor as shown in the screencapture, even if 
enlarged, willnot encroach on (-10, -10) area unless it's a inverted cursor 
wihch I am not sure exist or not.

> Shouldn't this use TESTCLASSES or something like that ?

We have used the same way of ImageIO.write() in jtreg tests

-------------

PR: https://git.openjdk.java.net/jdk/pull/6140

Reply via email to