On Tue, 16 Nov 2021 23:53:53 GMT, Alexander Zuev <[email protected]> wrote:
> Added implementation for all menu related protocol peers;
> Native methods moved to CommonComponentAccessibility so they are called on
> correct peers;
Besides what @savoptik mentioned, I left only cosmetics comments. Overall looks
ok to me.
src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m
line 1272:
> 1270: [ThreadUtilities performOnMainThread:@selector(postMenuOpened)
> 1271: on:(CommonComponentAccessibility *)jlong_to_ptr(element)
> 1272: withObject:nil waitUntilDone:NO];
Please move `waitUntilDone` to the new line for consistency.
src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/MenuAccessibility.m line
35:
> 33: - (NSAccessibilityRole _Nonnull)accessibilityRole
> 34: {
> 35: return [[[self parent] javaRole] isEqualToString:@"combobox"]
Please correct the indentation.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6421
