On Fri, 19 Nov 2021 20:21:27 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

> I am not sure that the bad_alloc will be properly handled in this 
> Java_sun_awt_shell_Win32ShellFolder2_getIconBits method.

I can't see any try-catch.
Is it better to use `malloc` and check for `NULL`?

> Probably it will be better to merge assigning into one line.

I agree. The line doesn't get too long.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6473

Reply via email to