On Tue, 30 Nov 2021 01:31:24 GMT, Liam Miller-Cushon <cus...@openjdk.org> wrote:
> This change updates the serialized objects used by > `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a similar > approach to the previous fix in > [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082). I must be losing it since I can't find a code review for the fix for https://bugs.openjdk.java.net/browse/JDK-8039082 Presumably the "fix" is to regenerate the serialized object files on some other platform beside mac ? But 8039082 was supposed to have done that, yet we clearly have a macOS class in here. I question the whole wisdom of including any Swing related classes in such a serialized form since Swing only supports short-term serialization. Not across platforms, not across releases. But still .. And isn't it just one of these cases that failed ? Did you have to re-generate all of them ? On which platform did you re-generate these ? And on which platforms did you then test the result ? I don't want to replace one failure with another. Also the test is now being problem-listed. https://github.com/openjdk/jdk/pull/6624 So this fix will need to de-problem list it. ------------- PR: https://git.openjdk.java.net/jdk/pull/6603
