On Thu, 2 Dec 2021 06:23:28 GMT, Liam Miller-Cushon <cus...@openjdk.org> wrote:
>>> I'm not sure I understand, aren't these being installed in `BasicPanelUI`? >> >> If it is installs in the BasicListUI only then yes the fix belongs to this >> class. These properties changing also in some other classes as well, but >> some other classes cleanup it properly for example see >> BasicListUI.uninstallDefaults(), but I am not sure that all of them do this. > >> These properties changing also in some other classes as well, but some other >> classes cleanup it properly for example see BasicListUI.uninstallDefaults(), >> but I am not sure that all of them do this. > > I looked through other uses of `installColorsAndFont`, and most of them don't > seem to be uninstalling the properties. I updated the ones I found, and added > a `uninstallColorsAndFont` method to avoid copying the logic around. @cushon As a best practice, please do not force push to a branch for which there is an PR under review. Instead, you can merge the master branch into your branch if you need to update. ------------- PR: https://git.openjdk.java.net/jdk/pull/6603
