On Fri, 10 Dec 2021 16:41:56 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add @since 19 to new methods > > @mrserb mentioned `BasicListUI.uninstallDefaults` uninstalls the colors > correctly. However, with the new methods added, it could use > `LookAndFeel.uninstallColorsAndFont` to reset its font, foreground and > background. > > Probably other UI classes should be updated too. @aivanov-jdk thanks, I updated `BasicListUI`. I found a few other cases with the following, which I have fixed: $ find src/java.desktop/share/ -type f -name '*.java' | xargs grep -l LookAndFeel.installColors | xargs grep -L LookAndFeel.uninstallColors The remaining files that call `LookAndFeel.installColors*` with a corresponding `uninstall*` call are below. This reference in javadoc seems fine: https://github.com/openjdk/jdk/blob/8eb453baebe377697286f7eb32280ca9f1fd7775/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthSpinnerUI.java#L116 This may be suspicious, but it isn't in an `install` method: https://github.com/openjdk/jdk/blob/8eb453baebe377697286f7eb32280ca9f1fd7775/src/java.desktop/share/classes/sun/swing/FilePane.java#L1295 ------------- PR: https://git.openjdk.java.net/jdk/pull/6603
