On Wed, 12 Jan 2022 02:40:22 GMT, Sergey Bylokhov <[email protected]> wrote:

>> Fix the typo in the constructor for BasicFileChooserUI.DoubleClickListener: 
>> ‘Constucts’ → ‘Constructs’.
>> Also fixed the typo in the parameter of the constructor: ‘the lsit’ → ‘the 
>> list’.
>> 
>> I also organised the imports which replaced all wildcard imports with 
>> specific class imports.
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java 
> line 73:
> 
>> 71: import javax.swing.plaf.FileChooserUI;
>> 72: import javax.swing.plaf.UIResource;
>> 73: 
> 
> I see that you added a line between different top packages, I use the same 
> style, but then it will make sense to do the same for java -> javax above.

Hm… Usually, there's no blank line between java- and javax- packages. Or I may 
have missed that it's the common practice.

In fact, I was thinking about adding a blank line in this case because the list 
of classes imported from either package is large.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7030

Reply via email to