On Thu, 10 Feb 2022 23:34:58 GMT, Phil Race <p...@openjdk.org> wrote:
>> Martin Desruisseaux has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add jtreg @test, @bug and @summary tags. Remove HTML <pre> tags. Edit
>> comments.
>
> test/jdk/java/awt/image/DrawImage/TiledImage.java line 98:
>
>> 96: */
>> 97: final class TiledImage implements RenderedImage {
>> 98: /**
>
> Still not right. Now you added the tags I ran under jtreg and it errored out.
> result: Error. java.lang.IllegalAccessException: class
> com.sun.javatest.regtest.agent.MainWrapper$MainThread cannot access a member
> of class TiledImage with modifiers "public static
>
> Basically change "final" to "public" - or at least add public.
>
> Might be prudent to try this for yourself - and useful for the future.
> jtreg instructions for building it can be found here :
> https://openjdk.java.net/jtreg/build.html
> Very possibly there's someone that provides a pre-built binary. There's none
> on OpenJDK.
Thanks for the tips and your patience. Actually I tried to run jtreg yesterday
before to commit the change, but got the following error (I wanted to try on
Java 17 first in order to verify that the test failed):
jtreg -jdk:$JAVA_HOME test/jdk/java/awt/image/DrawImage/TiledImage.java
failed to get value for vm.cds.write.archived.java.heap
java.lang.UnsatisfiedLinkError: 'boolean
jdk.test.whitebox.WhiteBox.canWriteJavaHeapArchive()'
at jdk.test.whitebox.WhiteBox.canWriteJavaHeapArchive(Native Method)
at requires.VMProps.vmCDSCanWriteArchivedJavaHeap(VMProps.java:413)
at requires.VMProps$SafeMap.put(VMProps.java:72)
at requires.VMProps.call(VMProps.java:113)
at requires.VMProps.call(VMProps.java:60)
at
com.sun.javatest.regtest.agent.GetJDKProperties.run(GetJDKProperties.java:80)
at
com.sun.javatest.regtest.agent.GetJDKProperties.main(GetJDKProperties.java:54)
I'm sure I did something wrong with my configuration…
-------------
PR: https://git.openjdk.java.net/jdk/pull/7337
