On Fri, 11 Feb 2022 07:30:28 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed test case to use BufferedImage to prevent retina-pixel scaling
>> issues
>
> test/jdk/javax/swing/JTableHeader/8016524/JTHeaderBorderTest.java line 90:
>
>> 88: String headerColor =
>> Integer.toHexString(table.getTableHeader().getBackground().getRGB());
>> 89: String pixelColor = tableColor;
>> 90: boolean isBottomLineVisible = false;
>
> To nitpick, I will much rather use Color instead of converting to String as
> we are trying to check and compare for Color but it's not a dealbreaker.
@prsadhuk BufferedImage's getRGB() method returns a int value and does not
have equivalent method that returns a Color object (at specified coordinates),
I was able to change string comparisons to int. Please let me know if this
should be okay?
> test/jdk/javax/swing/JTableHeader/8016524/JTHeaderBorderTest.java line 93:
>
>> 91:
>> 92: // scan table header region to check if bottom border of
>> JTableHeader is visible
>> 93: for (int y = Y_OFFSET; y <= Y_OFFSET+25; y++) {
>
> Can't we use X_OFFSET for hardcoded 25 here?
The X_OFFSET is different from the 25 specified in the loop, this specifies the
vertical scan range. To avoid confusion I have changed it as Y_OFFSET_START and
Y_OFFSET_END.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7219
