On Thu, 17 Feb 2022 05:06:55 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed review comments: frame created in EDT, waitForIdle() added after >> frame creation, editor access in EDT > > test/jdk/javax/swing/JTextArea/4514331/TabShiftsFocusToNextComponent.java > line 72: > >> 70: try { >> 71: SwingUtilities.invokeAndWait(() -> frame = new JFrame()); >> 72: robot.waitForIdle(); > > This robot.waitForIdle(); is not needed, the frame is not visible, so no > native peers are created->there are no events to flush. Call it after the > invokeAndWait below where the actual window will be created on the screen. Done > test/jdk/javax/swing/JTextArea/4514331/TabShiftsFocusToNextComponent.java > line 128: > >> 126: try { >> 127: UIManager.setLookAndFeel(laf); >> 128: System.out.println("LookAndFeel: " + laf); > > you should catch the UnsupportedLookAndFeelException, the gtk L&F might not > be supported even on the headful system. Done ------------- PR: https://git.openjdk.java.net/jdk/pull/7469