On Sat, 19 Feb 2022 00:43:39 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

>> Toshio Nakamura has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains ten additional 
>> commits since the last revision:
>> 
>>  - Revised according to review comments
>>  - Merge branch 'master' into 8240756
>>  - 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were 
>> garbled
>>  - revert previous proposal
>>  - Merge branch 'master' into 8240756
>>  - 2nd proposal
>>  - Revert previous change
>>  - Merge branch 'master' into 8240756
>>    merge master
>>  - 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were 
>> garbled
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CTextPipe.java line 156:
> 
>> 154:                 int slot = (gV.getGlyphCode(start) &
>> 155:                             CompositeGlyphMapper.SLOTMASK) >> 24;
>> 156:                 sg2d.setFont(getSlotFont(gV.getFont(), slot));
> 
> Do we need to change the font for each glyph or we should do that only if the 
> slot was changed? Or it is a common situation that each glyph will have its 
> own slot?

@mrserb Thank you for the comments.
Only if the slot was changed, we need to change the font. This may happen with 
multi-language situation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3619

Reply via email to